Open
Conversation
updating jest version was necessary
test explicitly overwrites private _sheet and doesn't mock spreadsheet behaviour for ranges and setting values on ranges
There was a type resolution conflict for type Mimetype for gas types. This default should work according to clasp documentation: https://github.com/google/clasp/blob/master/docs/typescript.md#typescript-configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't manage to use LockService API, i had no idea how to mock that. :-(
The new implementation for insertRows() inserts empty Rows and sets the values for the range explicitly if there are enough new rows to be inserted (currently >3). Otherwise sheet.appendRow will be called for each row.
Added a new unit test for insertRows to check this case: Gas does not provide an implementation for sheet.insertRowsAfter() and sheet.getRange().setValues(). So, instead the internal _sheet is overwritten ad hoc. I hate my solution!